From: Tejun Heo <tj@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org
Subject: Re: [PATCH 0/2] swim3: use blk_end_request_all()
Date: Wed, 13 May 2009 07:58:18 +0900 [thread overview]
Message-ID: <4A09FF0A.9030202@kernel.org> (raw)
In-Reply-To: <20090513005148A.fujita.tomonori@lab.ntt.co.jp>
Hello,
FUJITA Tomonori wrote:
>> It won't be freed. The current segment will be failed and the next
>> segment of the request will be tried on the next iteration, which was
>> the original behavior. ie. it always fails requests
>> segment-by-segment and hitting max retry count doesn't fail the whole
>> request.
>
> Ah, I see. Thanks, then the current code is fine.
>
> Well, it might be better to update some of the description of
> blk_update_request, e.g., "the special helper function is only for
> request stacking drivers".
Maybe but it encapsulates request details pretty well, so I wouldn't
really mind if it's used for other purposes (e.g. delaying actual
completion to ease internal bookkeeping).
Thanks.
--
tejun
prev parent reply other threads:[~2009-05-12 22:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 11:29 [PATCH 0/2] swim3: use blk_end_request_all() FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request_all when we hit the maximum retry count FUJITA Tomonori
2009-05-12 11:29 ` [PATCH] swim3: use blk_end_request instead of blk_update_request FUJITA Tomonori
2009-05-12 14:45 ` Boaz Harrosh
2009-05-12 15:06 ` FUJITA Tomonori
2009-05-12 15:27 ` Tejun Heo
2009-05-13 0:50 ` Kiyoshi Ueda
2009-05-13 5:49 ` Jens Axboe
2009-05-13 5:52 ` Tejun Heo
2009-05-13 5:59 ` Jens Axboe
2009-05-12 15:25 ` [PATCH 0/2] swim3: use blk_end_request_all() Tejun Heo
2009-05-12 15:31 ` FUJITA Tomonori
2009-05-12 15:36 ` Tejun Heo
2009-05-12 15:51 ` FUJITA Tomonori
2009-05-12 22:58 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A09FF0A.9030202@kernel.org \
--to=tj@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox