public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: Mats Erik Andersson <mats.andersson@gisladisker.se>
Cc: jbarnes@virtuousgeek.org, linux-kernel@vger.kernel.org,
	trivial@kernel.org
Subject: Re: [PATCH 1/1] pci: expose SMBus on Asus notebook A6L
Date: Tue, 12 May 2009 17:27:56 -0600	[thread overview]
Message-ID: <4A0A05FC.10906@gmail.com> (raw)
In-Reply-To: <20090512100523.GA31131@mea.homelinux.org>

Mats Erik Andersson wrote:
> From: Mats Erik Andersson <mats.andersson@gisladisker.se>
> 
> Addition of one unknown subsystem identifier to the
> quirks handler for chipset i82855GM_HB on notebook
> Asus A6L. This exposes the otherwise hidden SMBus
> controller within the south bridge ICH4-M.
> 
> Signed-off-by: Mats Erik Andersson <mats.andersson@gisladisker.se>
> ---
> 
> Tried and successfully used on kernel 2.6.29 and 2.6.23.17.
> 
> --- drivers/pci/quirks.c.orig	2009-05-09 00:47:21.000000000 +0200
> +++ drivers/pci/quirks.c	2009-05-12 11:20:04.000000000 +0200
> @@ -1068,8 +1068,9 @@ static void __init asus_hides_smbus_host
>  		else if (dev->device == PCI_DEVICE_ID_INTEL_82855GM_HB)
>  			switch (dev->subsystem_device) {
>  			case 0x1751: /* M2N notebook */
>  			case 0x1821: /* M5N notebook */
> +			case 0x1897: /* A6L notebook */
>  				asus_hides_smbus = 1;
>  			}
>  		else if (dev->device == PCI_DEVICE_ID_INTEL_82855PM_HB)
>  			switch (dev->subsystem_device) {

This has to be done with caution. If the BIOS accesses the SMBus 
controller from ACPI AML code or SMI code, then allowing a Linux driver 
to access the controller may cause problems.

  reply	other threads:[~2009-05-12 23:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-12 10:05 [PATCH 1/1] pci: expose SMBus on Asus notebook A6L Mats Erik Andersson
2009-05-12 23:27 ` Robert Hancock [this message]
2009-05-27  9:59   ` Mats Erik Andersson
2009-06-11 18:45 ` Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0A05FC.10906@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mats.andersson@gisladisker.se \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox