[PATCH] Allow deferrable timers for intervals tv2-tv5 to be deferred

[PATCH] Allow deferrable timers for intervals tv2-tv5 to be deferred

[Jon Hunter]

In the current kernel implementation only kernel timers for time 
interval tv1 are being deferred. This patch allows any timer that is 
configured as deferrable to be defer regardless of time interval.

This patch was previously discussed on another the thread [1] and Ack'ed 
  by Venki Pallipadi the author of the original deferrable timer patch.

Venki, could you also ack this patch for confirmation?

Cheers
Jon

[1] http://marc.info/?l=linux-kernel&m=123196343531966&w=2


Signed-off-by: Jon Hunter <jon-hunter@ti.com>
---
  kernel/timer.c |    3 +++
  1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index b455556..6ab6e96 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1012,6 +1012,9 @@ cascade:
  		index = slot = timer_jiffies & TVN_MASK;
  		do {
  			list_for_each_entry(nte, varp->vec + slot, entry) {
+				if (tbase_get_deferrable(nte->base))
+					continue;
+
  				found = 1;
  				if (time_before(nte->expires, expires))
  					expires = nte->expires;
-- 
1.6.1

Re: [PATCH] Allow deferrable timers for intervals tv2-tv5 to be deferred

[Pallipadi, Venkatesh]

On Thu, 2009-04-09 at 07:54 -0700, Jon Hunter wrote:
> In the current kernel implementation only kernel timers for time 
> interval tv1 are being deferred. This patch allows any timer that is 
> configured as deferrable to be defer regardless of time interval.
> 
> This patch was previously discussed on another the thread [1] and Ack'ed 
>   by Venki Pallipadi the author of the original deferrable timer patch.
> 
> Venki, could you also ack this patch for confirmation?
> 
> Cheers
> Jon
> 
> [1] http://marc.info/?l=linux-kernel&m=123196343531966&w=2
> 
> 

Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
> ---
>   kernel/timer.c |    3 +++
>   1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/timer.c b/kernel/timer.c
> index b455556..6ab6e96 100644
> --- a/kernel/timer.c
> +++ b/kernel/timer.c
> @@ -1012,6 +1012,9 @@ cascade:
>   		index = slot = timer_jiffies & TVN_MASK;
>   		do {
>   			list_for_each_entry(nte, varp->vec + slot, entry) {
> +				if (tbase_get_deferrable(nte->base))
> +					continue;
> +
>   				found = 1;
>   				if (time_before(nte->expires, expires))
>   					expires = nte->expires;

Re: [PATCH] Allow deferrable timers for intervals tv2-tv5 to be deferred

[ye janboe]

hi, Jon, Venki

This patch is same as Jouni Hogander's which has been acked by Venki
at 30 Jun 2008.
http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-06/msg11866.html

why Jouni Hogander's patch could not be accepted by LKML?

Thanks

Janboe

2009/4/10 Pallipadi, Venkatesh <venkatesh.pallipadi@intel.com>:
> On Thu, 2009-04-09 at 07:54 -0700, Jon Hunter wrote:
>> In the current kernel implementation only kernel timers for time
>> interval tv1 are being deferred. This patch allows any timer that is
>> configured as deferrable to be defer regardless of time interval.
>>
>> This patch was previously discussed on another the thread [1] and Ack'ed
>>   by Venki Pallipadi the author of the original deferrable timer patch.
>>
>> Venki, could you also ack this patch for confirmation?
>>
>> Cheers
>> Jon
>>
>> [1] http://marc.info/?l=linux-kernel&m=123196343531966&w=2
>>
>>
>
> Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
>
>> Signed-off-by: Jon Hunter <jon-hunter@ti.com>
>> ---
>>   kernel/timer.c |    3 +++
>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/kernel/timer.c b/kernel/timer.c
>> index b455556..6ab6e96 100644
>> --- a/kernel/timer.c
>> +++ b/kernel/timer.c
>> @@ -1012,6 +1012,9 @@ cascade:
>>               index = slot = timer_jiffies & TVN_MASK;
>>               do {
>>                       list_for_each_entry(nte, varp->vec + slot, entry) {
>> +                             if (tbase_get_deferrable(nte->base))
>> +                                     continue;
>> +
>>                               found = 1;
>>                               if (time_before(nte->expires, expires))
>>                                       expires = nte->expires;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] Allow deferrable timers for intervals tv2-tv5 to be deferred

[Jon Hunter]

ye janboe wrote:
> This patch is same as Jouni Hogander's which has been acked by Venki
> at 30 Jun 2008.
> http://linux.derkeiler.com/Mailing-Lists/Kernel/2008-06/msg11866.html
> 
> why Jouni Hogander's patch could not be accepted by LKML?

Before posting the patch I did search the archives but I did not come 
across Jouni's patch. Otherwise I probably would have reference this 
when posting this patch. Anyway, I am not sure why this was not accepted 
originally. It does not appear anyone responded to this. Sorry I cannot 
help more here.

Cheers
Jon