From: "B. N. Poornima" <poornima@in.ibm.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH]Fix potential Divide by Zero error in ext2_get_inode()
Date: Wed, 13 May 2009 13:51:01 +0530 [thread overview]
Message-ID: <4A0A82ED.2040906@in.ibm.com> (raw)
Found a line of code in ext2_get_inode function of inode.c in the ext2
filesystem that has the potential of hitting the divide by 0 error.
*************************************************
block_group = (ino - 1) / EXT2_INODES_PER_GROUP(sb);
*************************************************
There is no checking done here to verify if EXT2_INODES_PER_GROUP()
returns 0. This could result in divide by zero error and panic the system.
Below is the patch, built against 2.6.30-rc5, to correct the same:
Signed-off-by: B N Poornima <poornima@in.ibm.com>
Index: linux-2.6.30-rc5/fs/ext2/inode.c
===================================================================
--- linux-2.6.30-rc5.orig/fs/ext2/inode.c 2009-05-09
05:44:14.000000000 +0530
+++ linux-2.6.30-rc5/fs/ext2/inode.c 2009-05-12 19:14:42.873991280 +0530
@@ -1138,6 +1138,7 @@
unsigned long block_group;
unsigned long block;
unsigned long offset;
+ unsigned long inodes_per_group;
struct ext2_group_desc * gdp;
*p = NULL;
@@ -1145,7 +1146,10 @@
ino > le32_to_cpu(EXT2_SB(sb)->s_es->s_inodes_count))
goto Einval;
- block_group = (ino - 1) / EXT2_INODES_PER_GROUP(sb);
+ inodes_per_group = EXT2_INODES_PER_GROUP(sb);
+ if (!inodes_per_group)
+ goto Einval1;
+ block_group = (ino - 1) / inodes_per_group;
gdp = ext2_get_group_desc(sb, block_group, NULL);
if (!gdp)
goto Egdp;
@@ -1166,6 +1170,11 @@
ext2_error(sb, "ext2_get_inode", "bad inode number: %lu",
(unsigned long) ino);
return ERR_PTR(-EINVAL);
+
+Einval1:
+ printk(KERN_ERR "Ext2-fs: Filesystem corrupted. Wrong inodes per
group: %lu, run e2fsck\n", (unsigned long)inodes_per_group);
+ return ERR_PTR(-EINVAL);
+
Eio:
ext2_error(sb, "ext2_get_inode",
"unable to read inode block - inode=%lu, block=%lu",
next reply other threads:[~2009-05-13 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 8:21 B. N. Poornima [this message]
2009-05-13 22:04 ` [PATCH]Fix potential Divide by Zero error in ext2_get_inode() Andrew Morton
2009-05-14 11:37 ` B. N. Poornima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0A82ED.2040906@in.ibm.com \
--to=poornima@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox