Alan Stern wrote:
> On Tue, 12 May 2009, Jason Wessel wrote:
>
>   
>> +	if (!urb)
>> +		return;
>>     
>
> Is this test really needed?  
Doesn't look like it.
>
> Maybe you should pass a pointer to a usb_bus structure rather than an
> URB.  Then none of these issues would arise.
>
>   

I changed it to pass in the device instead (see attached)

>> +
>> +	hcd = bus_to_hcd(urb->dev->bus);
>> +	if (hcd)
>> +		usb_hcd_irq(0, hcd);
>>     
>
> This test too looks strange, since it can never fail.  (See the 
> definition of bus_to_hcd to find out why...)
>   

I agree.

Thanks,
Jason.