From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761377AbZEMQRd (ORCPT ); Wed, 13 May 2009 12:17:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761307AbZEMQQp (ORCPT ); Wed, 13 May 2009 12:16:45 -0400 Received: from easi.embeddedalley.com ([71.6.201.124]:48524 "HELO easi.embeddedalley.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1761076AbZEMQQo (ORCPT ); Wed, 13 May 2009 12:16:44 -0400 X-Greylist: delayed 401 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 May 2009 12:16:44 EDT Message-ID: <4A0AF0C7.5090104@embeddedalley.com> Date: Wed, 13 May 2009 20:09:43 +0400 From: Vladimir Barinov User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Daniel Mack CC: linux-kernel@vger.kernel.org, Sascha Hauer , Linux MTD list Subject: Re: [PATCH] mtd: mxc_nand: fix built breakage References: <1242229410-11853-1-git-send-email-daniel@caiaq.de> In-Reply-To: <1242229410-11853-1-git-send-email-daniel@caiaq.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Daniel, Please find the patch that I've sent some time ago. This patch should fix the issue you described. http://lists.infradead.org/pipermail/linux-mtd/2009-April/025363.html Vladimir Daniel Mack wrote: > The MXC NAND driver does not currently build with CONFIG_PM set. > > drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_suspend': > drivers/mtd/nand/mxc_nand.c:1021: error: 'nfc_clk' undeclared (first use in this function) > drivers/mtd/nand/mxc_nand.c:1021: error: (Each undeclared identifier is reported only once > drivers/mtd/nand/mxc_nand.c:1021: error: for each function it appears in.) > drivers/mtd/nand/mxc_nand.c: In function 'mxcnd_resume': > drivers/mtd/nand/mxc_nand.c:1033: error: 'nfc_clk' undeclared (first use in this function) > make[3]: *** [drivers/mtd/nand/mxc_nand.o] Error 1 > make[2]: *** [drivers/mtd/nand] Error 2 > make[1]: *** [drivers/mtd] Error 2 > make: *** [drivers] Error 2 > > Signed-off-by: Daniel Mack > Cc: Sascha Hauer > Cc: Linux MTD list > --- > drivers/mtd/nand/mxc_nand.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c > index 21fd4f1..d352d2a 100644 > --- a/drivers/mtd/nand/mxc_nand.c > +++ b/drivers/mtd/nand/mxc_nand.c > @@ -1011,6 +1011,8 @@ static int __devexit mxcnd_remove(struct platform_device *pdev) > static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > { > struct mtd_info *info = platform_get_drvdata(pdev); > + struct nand_chip *nand_chip = info->priv; > > + struct mxc_nand_host *host = nand_chip->priv; > int ret = 0; > > DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND suspend\n"); > @@ -1018,7 +1020,7 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > ret = info->suspend(info); > > /* Disable the NFC clock */ > - clk_disable(nfc_clk); /* FIXME */ > + clk_disable(host->clk); /* FIXME */ > > return ret; > } > @@ -1026,11 +1028,13 @@ static int mxcnd_suspend(struct platform_device *pdev, pm_message_t state) > static int mxcnd_resume(struct platform_device *pdev) > { > struct mtd_info *info = platform_get_drvdata(pdev); > + struct nand_chip *nand_chip = info->priv; > + struct mxc_nand_host *host = nand_chip->priv; > int ret = 0; > > DEBUG(MTD_DEBUG_LEVEL0, "MXC_ND : NAND resume\n"); > /* Enable the NFC clock */ > - clk_enable(nfc_clk); /* FIXME */ > + clk_enable(host->clk); /* FIXME */ > > if (info) > info->resume(info); >