public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Garrett D'Amore" <garrett@damore.org>
To: Pierre Ossman <pierre@ossman.eu>
Cc: Tobias Diedrich <ranma+kernel@tdiedrich.de>,
	SDHCI development <sdhci-devel@lists.ossman.eu>,
	linux-kernel@vger.kernel.org
Subject: Re: [Sdhci-devel] Ricoh R5C822 and QUIRK_FORCE_DMA
Date: Wed, 13 May 2009 11:09:37 -0700	[thread overview]
Message-ID: <4A0B0CE1.3060309@damore.org> (raw)
In-Reply-To: <20090513195956.30f78012@mjolnir.ossman.eu>

I know that we've run into some bizarre behavior with Ricoh controllers 
and DMA in the Solaris implementation of sdhost.  Specifically, what we 
ran into was problems with DMA across certain alignment boundaries.  It 
seems that when a DMA operation is not aligned on a 512 boundary, or 
does something less than a 512 byte transfer, it has trouble.

In the Solaris driver, I just allocate a big 64k page-aligned chunk for 
DMA, and use bcopy to/from that.  Frankly, bcopy is fast enough, that it 
makes little performance difference.  Plus, it means that I can use a 
larger interrupt threshold than 4K, allowing me to skip the 
scatter/gather overhead... I suspect that this negates the cost of the 
bcopy.

After doing this, the Lenovo and Toshiba laptops that I've had access to 
work well.

    - Garrett

Pierre Ossman wrote:
> (cc:ing sdhci-devel)
>
> On Fri, 1 May 2009 00:45:24 +0200
> Tobias Diedrich <ranma+kernel@tdiedrich.de> wrote:
>
>   
>> Do you know any controller bugs for this revision which may be the
>> reason for not advertising DMA capability?
>> I haven't done any big tests yet, but at first glance it seems to
>> read/write the card just fine.
>>
>>     
>
> Might be a system problem so it's Lenovo that disabled it. You're the
> first report I've seen on this since the DMA logic was reworked so that
> DMA didn't have to be forced for most cases.
>
> Is there anyone else reading this that are having DMA problems?
>
> Rgds
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> sdhci-devel mailing list
> sdhci-devel@lists.ossman.eu
> http://list.drzeus.cx/mailman/listinfo/sdhci-devel
>   


  reply	other threads:[~2009-05-13 18:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30 22:45 Ricoh R5C822 and QUIRK_FORCE_DMA Tobias Diedrich
2009-05-13 17:59 ` Pierre Ossman
2009-05-13 18:09   ` Garrett D'Amore [this message]
2009-06-09 22:41   ` QUIRK_FORCE_HISPD (was: Re: Ricoh R5C822 and QUIRK_FORCE_DMA) Tobias Diedrich
2009-06-13 10:53     ` Pierre Ossman
2009-08-01  5:17       ` Tobias Diedrich
2009-09-06 13:30         ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0B0CE1.3060309@damore.org \
    --to=garrett@damore.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre@ossman.eu \
    --cc=ranma+kernel@tdiedrich.de \
    --cc=sdhci-devel@lists.ossman.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox