From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752251AbZENAPW (ORCPT ); Wed, 13 May 2009 20:15:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754773AbZENAPG (ORCPT ); Wed, 13 May 2009 20:15:06 -0400 Received: from mail-gx0-f166.google.com ([209.85.217.166]:58900 "EHLO mail-gx0-f166.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754439AbZENAPF (ORCPT ); Wed, 13 May 2009 20:15:05 -0400 Message-ID: <4A0B6283.9040106@codemonkey.ws> Date: Wed, 13 May 2009 19:14:59 -0500 From: Anthony Liguori User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Chris Wright CC: Andrew Morton , Izik Eidus , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, avi@redhat.com, aarcange@redhat.com, mtosatti@redhat.com, hugh@veritas.com Subject: Re: [PATCH 5/5] add ksm kernel shared memory driver. References: <1240191366-10029-1-git-send-email-ieidus@redhat.com> <1240191366-10029-2-git-send-email-ieidus@redhat.com> <1240191366-10029-3-git-send-email-ieidus@redhat.com> <1240191366-10029-4-git-send-email-ieidus@redhat.com> <1240191366-10029-5-git-send-email-ieidus@redhat.com> <1240191366-10029-6-git-send-email-ieidus@redhat.com> <20090513161739.d801ab67.akpm@linux-foundation.org> <20090513232520.GN12533@x200.localdomain> In-Reply-To: <20090513232520.GN12533@x200.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chris Wright wrote: > * Andrew Morton (akpm@linux-foundation.org) wrote: > >> Breaks ppc64 allmodcofnig because that architecture doesn't export its >> copy_user_page() to modules. >> > > Things like this and updating to use madvise() I think all point towards > s/tristate/bool/. I don't think CONFIG_KSM=M has huge benefit. > I agree. Regards, Anthony Liguori