Re: [PATCH v3] ftrace: add a tracepoint for __raise_softirq_irqoff()

Xiao Guangrong
2009-05-07T00:56:36Z

Li Zefan wrote:
>> +TRACE_EVENT(irq_softirq_raise,
>
> I think 'softirq_raise' is better.
>
>> +
>> + TP_PROTO(unsigned int nr),
>> +
>> + TP_ARGS(nr),
>> +
>> + TP_STRUCT__entry(
>> + __field( unsigned int, nr )
>> + ),
>> +
>> + TP_fast_assign(
>> + __entry->nr = nr;
>> + ),
>> +
>> + TP_printk("softirq=%d action=%s is raised",
>> + __entry->nr, softirq_to_name[__entry->nr])
>
> "softirq=%d action=%s" is sufficient.
>
> Please see TRACE_EVENT(softirq_entry) and TRACE_EVENT(softirq_exit).
>

Thanks, I will modify it as your suggestions. ;-)

>
>> +);
>> +