public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <roel.kluin@gmail.com>
To: alan@redhat.com
Cc: lkml <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] gs: missing parentheses
Date: Thu, 14 May 2009 12:11:24 +0200	[thread overview]
Message-ID: <4A0BEE4C.30600@gmail.com> (raw)

`|' has a higher precedence than `?' so add parentheses.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index 518f2a2..1f63add 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -979,8 +979,8 @@ static int sx_set_real_termios(void *ptr)
 			(I_IXANY(port->gs.port.tty) ? SP_TANY : 0) | SP_DCEN);
 
 	sx_write_channel_byte(port, hi_break,
-			(I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0 |
-			I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
+			(I_IGNBRK(port->gs.port.tty) ? BR_IGN : 0) |
+			(I_BRKINT(port->gs.port.tty) ? BR_INT : 0));
 
 	sx_write_channel_byte(port, hi_txon, START_CHAR(port->gs.port.tty));
 	sx_write_channel_byte(port, hi_rxon, START_CHAR(port->gs.port.tty));

             reply	other threads:[~2009-05-14 10:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-14 10:11 Roel Kluin [this message]
2009-05-14 10:25 ` [PATCH] gs: missing parentheses Viral Mehta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0BEE4C.30600@gmail.com \
    --to=roel.kluin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox