From: Tejun Heo <tj@kernel.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
jens.axboe@oracle.com, James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] block: completion related functions cleanup
Date: Thu, 14 May 2009 23:05:09 +0900 [thread overview]
Message-ID: <4A0C2515.9060602@kernel.org> (raw)
In-Reply-To: <4A0C2297.5040001@panasas.com>
Boaz Harrosh wrote:
> ---
> drivers/scsi/scsi_lib.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index e410d66..f8600d6 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -789,7 +789,6 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
> */
> if (scsi_end_request(cmd, error, good_bytes, result == 0) == NULL)
> return;
> - this_count = blk_rq_bytes(req);
>
> error = -EIO;
>
Nice spotting. Looks like the variable can be killed completely?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-05-14 14:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 8:56 [PATCH 0/3] block: completion releated functions cleanup FUJITA Tomonori
2009-05-11 8:56 ` [PATCH 1/3] block: let blk_end_request_all handle bidi requests FUJITA Tomonori
2009-05-11 9:06 ` Jens Axboe
2009-05-11 9:11 ` FUJITA Tomonori
2009-05-11 9:16 ` Jens Axboe
2009-05-11 8:56 ` [PATCH 2/3] scsi: simplify the bidi completion FUJITA Tomonori
2009-05-11 8:56 ` [PATCH 3/3] block: move completion related functions back to blk-core.c FUJITA Tomonori
2009-05-11 9:06 ` [PATCH 0/3] block: completion releated functions cleanup Jens Axboe
2009-05-14 13:54 ` [PATCH 0/3] block: completion related " Boaz Harrosh
2009-05-14 14:05 ` Tejun Heo [this message]
2009-05-14 14:15 ` Boaz Harrosh
2009-05-14 15:46 ` Tejun Heo
2009-05-15 0:12 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0C2515.9060602@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bharrosh@panasas.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox