From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760095AbZEOBxZ (ORCPT ); Thu, 14 May 2009 21:53:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753985AbZEOBxP (ORCPT ); Thu, 14 May 2009 21:53:15 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:60260 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753900AbZEOBxO (ORCPT ); Thu, 14 May 2009 21:53:14 -0400 Message-ID: <4A0CCB2E.10202@cn.fujitsu.com> Date: Fri, 15 May 2009 09:53:50 +0800 From: Xiao Guangrong User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Steven Rostedt CC: Mathieu Desnoyers , mingo@elte.hu, linux-kernel@vger.kernel.org, fweisbec@gmail.com, zhaolei@cn.fujitsu.com, laijs@cn.fujitsu.com, Li Zefan Subject: Re: [PATCH v4] ftrace: add a tracepoint for __raise_softirq_irqoff() References: <49FFDF9C.7040505@cn.fujitsu.com> <20090505161604.GA15524@Krystal> <4A07D3B3.10605@cn.fujitsu.com> <20090511134019.GB10932@Krystal> <20090511142734.GA12722@Krystal> <20090511151353.GA14391@Krystal> <4A094677.5090900@cn.fujitsu.com> <4A0BF82A.2070208@cn.fujitsu.com> <20090514124013.GC21241@Krystal> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Steven Rostedt wrote: > On Thu, 14 May 2009, Mathieu Desnoyers wrote: >>> From: Mathieu Desnoyers >>> >>> This patch is modified from Mathieu Desnoyers' patch. The original patch >>> can be found here: >>> http://marc.info/?l=linux-kernel&m=123791201816245&w=2 >>> This tracepoint can trace the time stamp when softirq action is raised. >>> >>> Changelog for v1 -> v2: >>> 1: Use TRACE_EVENT instead of DEFINE_TRACE >>> 2: Move the tracepoint from raise_softirq_irqoff() to >>> __raise_softirq_irqoff() >>> >>> Changelog for v2 -> v3: >>> Move the definition of __raise_softifq_irqoff() to .c file when >>> CONFIG_TRACEPOINTS is enabled, to avoid recursive includes >>> >>> Changelog for v3 -> v4: >>> 1: Come back to v2, and use forward declarations to avoid >>> recursive includes as Mathieu's suggestion >>> 2: Modifiy the tracepoint name >>> 3: Add comments for this tracepoint >>> >> This is a step in the right direction, but please see my email to Lai >> about the fact that this assumes correct and undocumented include >> dependencies in kernel/trace/events.c. Not explicitely stating the >> include dependencies is a build error waiting to happen. >> >> Including interrupt.h under a ifdef would allow keeping track of >> TRACE_EVENT specific build dependencies neatly on a per header basis. > > This is all moot, the events.c file no longer exists and as not an issue. > As Steve's says, use ftrace in ftrace.h not in events.c now. So, this mistake does not exist. Dose this patch has other error? I expect for your views. Thanks for your review, is great help to me. ;-) > -- Steve > > >