Re: [GIT PATCH] x86,percpu: fix pageattr handling with remap allocator

Tejun Heo
2009-05-21T00:08:00Z

Hello,

Suresh Siddha wrote:
>> Hmmm... I can't really follow what you're suggesting. Can you please
>> explain it in more detailed way?
>
> Ok. Before I make another attempt walking that hill :)

Heh... the problem is that unless I understand what you're trying to
achieve (and vice-versa), our discussion is likely to be riddled with
confusions, and currently either you're misunderstanding the whole
thing or I'm being slow (not too unusual :-). It would be nice to
determine which way it is.

> I was talking to Peter and it seems there are some requests to change
> the first percpu unit allocation for each possible cpu using bootmem
> allocator, to allocating the corresponding unit at the cpu online time.
>
> Do you have plans to change this?

Yeap, once the remaining archs are converted, that's the next stop.
With recently posted patchset, only three remain - sparc64, powerpc64
and sparc64. Davem is working on sparc64. I'm planning on doing
powerpc64. ia64 is a bit tricky as it already remaps percpu areas but
I'm sure we'll find a way around it. After that, yeap, the dynamic
online thing.

> If we do this allocation during the corresponding cpu online time
> and don't end up using big pages, then also we avoid all these
> aliasing issues...

The dynamic onlining will probably use 4k pages so, yeah, it won't
have the alias issues but that's not the issue here, right? You can
already avoid aliasing that way by simply using 4k allocator from the
get-go.

Thanks.

--
tejun