Re: [patch 29/51] mac80211: pid, fix memory corruption

Greg KH
2009-05-15T14:53:41Z

On Fri, May 15, 2009 at 08:23:50AM +0200, Jiri Slaby wrote:
> Hi,
>
> note that you were about to drop this one now because of waiting for a
> fixup which is not upstream so far. Did anything change?

Hm, no, I dropped a different patch,
mac80211-minstrel-fix-memory-corruption.patch
did I drop the wrong one?

Should I bring that one back and drop the one below?

confused,

greg k-h

> (This is the one which fixes a memory corruption, but triggers a bug
> causing oopses on single band cards.)
>
> On 05/15/2009 12:33 AM, Greg KH wrote:
> From: Jiri Slaby <jirislaby@gmail.com>
>
> commit 6909268dc93ae4b0b8e1ebb4b2fa70b1a47dd347 upstream.
>
> pid doesn't count with some band having more bitrates than the one
> associated the first time.
> Fix that by counting the maximal available bitrate count and allocate
> big enough space.
>
> Secondly, fix touching uninitialized memory which causes panics.
> Index sucked from this random memory points to the hell.
> The fix is to sort the rates on each band change.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>