Re: [patch 06/51] usb-serial: ftdi_sio: fix reference counting of ftdi_private

David Woodhouse
2009-05-18T12:46:52Z

On Thu, 2009-05-14 at 15:32 -0700, Greg KH wrote:
> 2.6.29-stable review patch. If anyone has any objections, please let
> us know.
>
> ------------------
>
> From: Alan Stern <stern@rowland.harvard.edu>
>
> commit c45d63202fbaccef7ef7946c03f27f72c809b1cc upstream.
>
> This patch (as1238) adds proper reference counting for ftdi_sio's
> private data structure. Without it, the driver will free the
> structure while it is still in use if the user unplugs the serial
> device before closing the device file.
>
> The patch also replaces a slightly dangerous
> cancel_delayed_work/flush_scheduled_work pair with
> cancel_delayed_work_sync, which is always safer.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> Reported-by: Daniel Mack <daniel@caiaq.de>
> Tested-by: Daniel Mack <daniel@caiaq.de>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

Works for me as long as you include the incremental patch I just sent.

--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation