public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wei Yongjun <yjwei@cn.fujitsu.com>
To: Al Viro <viro@zeniv.linux.org.uk>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] devpts: change the default value of devpts mode to 0620
Date: Fri, 15 May 2009 16:13:44 +0800	[thread overview]
Message-ID: <4A0D2438.7020509@cn.fujitsu.com> (raw)
In-Reply-To: <4A0CFCD0.70605@cn.fujitsu.com>

The value of devpts mode is usually set to 620 in file
/etc/fstab like this:

$grep devpts /etc/fstab
devpts /dev/pts devpts gid=5,mode=620 0 0

But the default mode value of devpts is 0600. Why not
set it to 0620? This patch change it 0620.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
fs/devpts/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 13392b5..33430b9 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -26,7 +26,7 @@

#define DEVPTS_SUPER_MAGIC 0x1cd1

-#define DEVPTS_DEFAULT_MODE 0600
+#define DEVPTS_DEFAULT_MODE 0620
/*
* ptmx is a new node in /dev/pts and will be unused in legacy (single-
* instance) mode. To prevent surprises in user space, set permissions of
-- 
1.5.3.8


  reply	other threads:[~2009-05-15  8:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15  5:20 [PATCH] devpts: fix to set default values of mount options Wei Yongjun
2009-05-15  5:25 ` [PATCHv2] " Wei Yongjun
2009-05-15  8:13   ` Wei Yongjun [this message]
2009-05-15  9:50     ` [PATCH] devpts: change the default value of devpts mode to 0620 Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0D2438.7020509@cn.fujitsu.com \
    --to=yjwei@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox