public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	Boaz Harrosh <bharrosh@panasas.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	IDE/ATA development list <linux-ide@vger.kernel.org>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Borislav Petkov <petkovbb@googlemail.com>,
	Pete Zaitcev <zaitcev@redhat.com>,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>,
	Eric Moore <Eric.Moore@lsi.com>,
	"Darrick J. Wong" <djwong@us.ibm.com>
Subject: [PATCH block#for-2.6.31 3/3] bio: always copy back data for copied kernel requests
Date: Sat, 16 May 2009 00:19:19 +0900	[thread overview]
Message-ID: <4A0D87F7.8090401@gmail.com> (raw)
In-Reply-To: <4A0D87D2.7090806@gmail.com>

When a read bio_copy_kern() request fails, the content of the bounce
buffer is not copied back.  However, as request failure doesn't
necessarily mean complete failure, the buffer state can be useful.
This behavior is also inconsistent with the user map counterpart and
causes the subtle difference between bounced and unbounced IO causes
confusion.

This patch makes bio_copy_kern_endio() ignore @err and always copy
back data on request completion.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
---
 fs/bio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: block/fs/bio.c
===================================================================
--- block.orig/fs/bio.c
+++ block/fs/bio.c
@@ -1198,7 +1198,7 @@ static void bio_copy_kern_endio(struct b
 		char *addr = page_address(bvec->bv_page);
 		int len = bmd->iovecs[i].bv_len;
 
-		if (read && !err)
+		if (read)
 			memcpy(p, addr, len);
 
 		__free_page(bvec->bv_page);

  reply	other threads:[~2009-05-15 15:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-15 15:14 [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all() Tejun Heo
2009-05-15 15:18 ` [PATCH block#for-2.6.31 2/3] block: set rq->resid_len to blk_rq_bytes() on issue Tejun Heo
2009-05-15 15:19   ` Tejun Heo [this message]
2009-05-15 15:38   ` Sergei Shtylyov
2009-05-15 22:18     ` Tejun Heo
2009-05-16 12:29       ` Sergei Shtylyov
2009-05-16 13:48         ` Tejun Heo
2009-05-15 17:29   ` Pete Zaitcev
2009-05-15 22:14     ` Tejun Heo
2009-05-15 23:16       ` Pete Zaitcev
2009-05-16  0:14         ` Tejun Heo
2009-05-16  0:18   ` [PATCH UPDATED " Tejun Heo
2009-05-17  8:48     ` Boaz Harrosh
2009-05-17 11:32       ` Tejun Heo
2009-05-17 11:41         ` Tejun Heo
2009-05-17 12:05     ` [PATCH UPDATED2 " Tejun Heo
2009-05-18 12:49       ` Jens Axboe
2009-05-19  9:14         ` Tejun Heo
2009-05-19  9:17           ` Jens Axboe
2009-05-16  7:13   ` [PATCH " Borislav Petkov
2009-05-16 13:52     ` Tejun Heo
2009-05-15 17:31 ` [PATCH block#for-2.6.31 1/3] ub: use __blk_end_request_all() Pete Zaitcev
2009-05-15 22:19   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0D87F7.8090401@gmail.com \
    --to=htejun@gmail.com \
    --cc=Eric.Moore@lsi.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bharrosh@panasas.com \
    --cc=bzolnier@gmail.com \
    --cc=djwong@us.ibm.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    --cc=sshtylyov@ru.mvista.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox