From: Andi Kleen <ak@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ian Campbell <ian.campbell@citrix.com>,
Jakub Jelinek <jakub@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Hugh Dickins <hugh@veritas.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix print out of function which called WARN_ON()
Date: Fri, 15 May 2009 21:50:47 +0200 [thread overview]
Message-ID: <4A0DC797.7040502@linux.intel.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0905151018370.3343@localhost.localdomain>
Linus Torvalds wrote:
> [ Jakub - I added you to the participants list because it really looks
> like this patch (without 'noinline') triggers a gcc bug.
This whole thing seems to be much more problematic than I originally thought :-/
Maybe it's better to just give up on gcc 3.2 instead and forbid it and revert
my original patch. That would have the advantage that we wouldn't need
to worry about the inline heuristics on that old compiler too (that was
the reason I even tested it)
Given the smaller code size was a nice bonus, but it wasn't a big difference.
-Andi
next prev parent reply other threads:[~2009-05-15 19:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 16:17 [PATCH] Fix print out of function which called WARN_ON() Ian Campbell
2009-05-15 17:52 ` Linus Torvalds
2009-05-15 19:50 ` Andi Kleen [this message]
2009-05-16 20:47 ` Linus Torvalds
2009-05-17 14:43 ` Hugh Dickins
2009-05-17 22:18 ` Linus Torvalds
2009-05-17 22:24 ` David Miller
2009-05-17 22:47 ` Linus Torvalds
2009-05-17 22:45 ` Hugh Dickins
2009-05-17 22:54 ` Linus Torvalds
2009-05-18 9:09 ` Ian Campbell
2009-05-18 14:11 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0DC797.7040502@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hugh@veritas.com \
--cc=ian.campbell@citrix.com \
--cc=jakub@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox