public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarek Poplawski <jarkao2@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: "Alexander V. Lukyanov" <lav@netis.ru>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.29.1: unregister_netdevice problem
Date: Sat, 16 May 2009 09:06:29 +0200	[thread overview]
Message-ID: <4A0E65F5.1040906@gmail.com> (raw)
In-Reply-To: <20090515101209.GA6367@ff.dom.local>

Jarek Poplawski wrote, On 05/15/2009 12:12 PM:

> On Fri, May 15, 2009 at 12:54:14PM +0400, Alexander V. Lukyanov wrote:
>> On Fri, May 15, 2009 at 08:06:49AM +0000, Jarek Poplawski wrote:
>>> On Fri, May 15, 2009 at 11:19:46AM +0400, Alexander V. Lukyanov wrote:
>>> ...
>>>> Looks like 2.6.28.10 does not have this refcnt problem. Also, after I have
>>>> reversed net/ipv4/route.c changes from 2.6.29, the problem does not occur either.
>>> Very nice work! It should be a piece of cake now - there were not much
>>> changes. I'll look at it, as usual ;-), but, of course if it's
>>> possible, it would be great to try "in the meantime" with reverted the
>>> biggest of them append below.
>> I suspect the problem occurs when cand==rthi.
> 
> Looks like good catch! (But there could be more than this.) Then, of
> course it would be interesting to try first some fix (like nulling
> rthi after rt_free(cand), I guess).


On the other hand, since this looks like quite obvious bug (even if it
doesn't fix your problem), feel free to send here a patch fixing it any
way you like without waiting for the final test results (Cc-ing authors
of the offending patch, I hope).

Jarek P.

      reply	other threads:[~2009-05-16  7:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  5:57 2.6.29.1: unregister_netdevice problem Alexander V. Lukyanov
2009-04-23 23:30 ` Eric W. Biederman
2009-04-24 21:16   ` Bruno Prémont
2009-04-27  5:41 ` Alexander V. Lukyanov
2009-04-28 12:57   ` Alexander V. Lukyanov
2009-04-28 20:49     ` Jarek Poplawski
2009-04-29  5:45       ` Alexander V. Lukyanov
2009-04-29  9:08         ` Jarek Poplawski
2009-05-08  6:26           ` Alexander V. Lukyanov
2009-05-08 10:46             ` Jarek Poplawski
2009-05-10  7:35               ` Alexander V. Lukyanov
2009-05-10 12:46                 ` Jarek Poplawski
2009-05-15  7:19                   ` Alexander V. Lukyanov
2009-05-15  8:06                     ` Jarek Poplawski
2009-05-15  8:54                       ` Alexander V. Lukyanov
2009-05-15 10:12                         ` Jarek Poplawski
2009-05-16  7:06                           ` Jarek Poplawski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A0E65F5.1040906@gmail.com \
    --to=jarkao2@gmail.com \
    --cc=lav@netis.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox