From: Avi Kivity <avi@redhat.com>
To: Gregory Haskins <ghaskins@novell.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [KVM PATCH v2 4/4] kvm: add iosignalfd support
Date: Sun, 17 May 2009 23:15:10 +0300 [thread overview]
Message-ID: <4A10704E.1080301@redhat.com> (raw)
In-Reply-To: <20090515162823.26209.72294.stgit@dev.haskins.net>
Gregory Haskins wrote:
> +
> +struct _iosignalfd {
>
Why the underscore? It's unorthodox for a structure.
> + u64 cookie;
> + u64 addr;
> + size_t length;
> + struct file *file;
> + struct list_head list;
> + struct kvm_io_device dev;
> +};
>
How will that work with multiple identical addresses and different
cookies? Will the code iterate over all of them and just fire for one?
I guess that's the best way for now.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-05-17 20:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 16:28 [KVM PATCH v2 0/4] iosignalfd Gregory Haskins
2009-05-15 16:28 ` [KVM PATCH v2 1/4] eventfd: export eventfd interfaces for module use Gregory Haskins
2009-05-15 16:28 ` [KVM PATCH v2 2/4] kvm: add return value to kvm_io_bus_register_dev Gregory Haskins
2009-05-17 20:10 ` Avi Kivity
2009-05-18 2:31 ` Gregory Haskins
2009-05-15 16:28 ` [KVM PATCH v2 3/4] kvm: add io_bus unregister function Gregory Haskins
2009-05-15 16:28 ` [KVM PATCH v2 4/4] kvm: add iosignalfd support Gregory Haskins
2009-05-17 20:15 ` Avi Kivity [this message]
2009-05-18 2:37 ` Gregory Haskins
2009-05-15 16:35 ` [KVM PATCH v2 0/4] iosignalfd Gregory Haskins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A10704E.1080301@redhat.com \
--to=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox