Re: [PATCH 11/11] mm: Convert #ifdef DEBUG printk(KERN_DEBUG to pr_debug(

Serge E. Hallyn
2009-05-15T18:56:21Z

Quoting Joe Perches (joe@perches.com):
> From: Joe Perches <joe@perches.com>
>
> Signed-off-by: Joe Perches <joe@perches.com>

Seems reasonable - apart from my woes with dynamic_printk :)

Can you also remove the commented-out '#define DEBUG' line on
line 35 if you haven't already?

Acked-by: Serge Hallyn <serue@us.ibm.com>

thanks,
-serge

> ---
> mm/oom_kill.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 92bcf1d..8f7fb51 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -159,10 +159,8 @@ unsigned long badness(struct task_struct *p, unsigned long uptime)
> points >>= -(p->oomkilladj);
> }
>
> -#ifdef DEBUG
> - printk(KERN_DEBUG "OOMkill: task %d (%s) got %lu points\n",
> - p->pid, p->comm, points);
> -#endif
> + pr_debug("OOMkill: task %d (%s) got %lu points\n",
> + p->pid, p->comm, points);
> return points;
> }
>
> --
> 1.6.3.1.9.g95405b.dirty