Re: [PATCH version 2] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31 tree

Boaz Harrosh
2009-05-20T17:03:21Z

On 05/20/2009 07:59 PM, Boaz Harrosh wrote:
> On 05/20/2009 07:43 PM, James Bottomley wrote:
>> If you actually just ask scsi-post-merge-2.6 where this line is, it will
>> tell you:
>>
>> static void blk_finish_request(struct request *req, int error)
>> {
>> BUG_ON(blk_queued_rq(req));
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> if (blk_rq_tagged(req))
>> blk_queue_end_tag(req->q, req);
>>
>> James
>>
>>
>
> This is a new BUG_ON from:
> block: implement and enforce request peek/start/fetch
>
> It looks like there is one more sight of the old usage that
> was not converted.
>
> Tejun?
>

The patch has a comment about that:
* disallowing completion of queued (not started) requests

Do you have a stack trace?

Boaz