From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752020AbZESKOx@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752020AbZESKOx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2009 06:14:53 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752701AbZESKOp
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 19 May 2009 06:14:45 -0400
Received: from gw-ca.panasas.com ([209.116.51.66]:30004 "EHLO
	laguna.int.panasas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1752354AbZESKOo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2009 06:14:44 -0400
Message-ID: <4A12868E.6030108@panasas.com>
Date: Tue, 19 May 2009 13:14:38 +0300
From: Boaz Harrosh <bharrosh@panasas.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090315 Remi/3.0-0.b2.fc10.remi Thunderbird/3.0b2
MIME-Version: 1.0
To: Tejun Heo <tj@kernel.org>
CC: Stephen Rothwell <sfr@canb.auug.org.au>,
       James Smart <James.Smart@Emulex.Com>,
       James Bottomley <James.Bottomley@hansenpartnership.com>,
       linux-scsi <linux-scsi@vger.kernel.org>,
       FUJITA Tomonori <tomof@acm.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>,
       Jens Axboe <Jens.Axboe@oracle.com>
Subject: Re: [PATCH] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31
 tree
References: <4A12797B.2060901@panasas.com> <4A128484.4000708@kernel.org>
In-Reply-To: <4A128484.4000708@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 19 May 2009 10:14:43.0030 (UTC) FILETIME=[A0A87F60:01C9D86A]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/19/2009 01:05 PM, Tejun Heo wrote:
> Hello, Boaz.
> 
> Just two minor things.
> 
> Boaz Harrosh wrote:
>>  	/* we assume all request payload was transferred, residual == 0 */
>> -	req->data_len = 0;
>> +	req->resid_len = 0;
>>  
>>  	if (rsp) {
>> -		rsp_len = blk_rq_bytes(rsp);
>> -		BUG_ON(job->reply->reply_payload_rcv_len > rsp_len);
> 
> Maybe convert it to WARN_ON() instead of removing?

Sorry, You are absolutely correct should add it back. (With a WARN_ON)

> 
>>  		/* set reply (bidi) residual */
>> -		rsp->data_len = (rsp_len - job->reply->reply_payload_rcv_len);
>> +		rsp->resid_len = blk_rq_bytes(rsp) -
>> +					job->reply->reply_payload_rcv_len;
> 
> With the fix-fallouts patchset it, this can be
> 
> 	rsp->resid_len -= job->reply->reply_payload_rcv_len;
> 

Sure.

> Other than above misc points,
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> 

Will repost as reply to Original patch, thanks
Boaz