From: Yinghai Lu <yinghai@kernel.org>
To: Jack Steiner <steiner@sgi.com>
Cc: mingo@elte.hu, tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64 - UV fix for memory-only blades
Date: Tue, 19 May 2009 08:13:05 -0700 [thread overview]
Message-ID: <4A12CC81.30108@kernel.org> (raw)
In-Reply-To: <20090515194508.GA8305@sgi.com>
Jack Steiner wrote:
> Fix an endcase in handling UV blades that have memory
> but no cpus. The calculation of the highest blade number
> failed to handle these blades if they appear last in the
> configuration.
>
> Signed-off-by: Jack Steiner <steiner@sgi.com>
>
> ---
> arch/x86/kernel/apic/x2apic_uv_x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux/arch/x86/kernel/apic/x2apic_uv_x.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/apic/x2apic_uv_x.c 2009-05-15 12:00:59.000000000 -0500
> +++ linux/arch/x86/kernel/apic/x2apic_uv_x.c 2009-05-15 14:38:16.000000000 -0500
> @@ -632,6 +632,7 @@ void __init uv_system_init(void)
> pnode = (paddr >> m_val) & pnode_mask;
> blade = boot_pnode_to_blade(pnode);
> uv_node_to_blade[nid] = blade;
> + max_pnode = max(pnode, max_pnode);
> }
>
> map_gru_high(max_pnode);
node_possible_map should already include nodes with memory and without memory already.
maybe you could skip max_pnode calculating in the loop.
YH
next prev parent reply other threads:[~2009-05-19 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 19:45 [PATCH] x86_64 - UV fix for memory-only blades Jack Steiner
2009-05-19 15:13 ` Yinghai Lu [this message]
2009-05-20 16:13 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A12CC81.30108@kernel.org \
--to=yinghai@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).