From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Ingo Molnar <mingo@elte.hu>, Jiri Slaby <jirislaby@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing: use strlcpy instead of strncpy
Date: Wed, 20 May 2009 10:34:20 +0800 [thread overview]
Message-ID: <4A136C2C.1010107@cn.fujitsu.com> (raw)
In-Reply-To: <4A12AC0D.7000701@s5r6.in-berlin.de>
Stefan Richter wrote:
> Lai Jiangshan wrote:
>> [Impact] cleanup
>
> Well, not entirely.
>
>> --- a/kernel/trace/trace.h
>> +++ b/kernel/trace/trace.h
>> @@ -155,8 +155,8 @@ struct trace_boot_ret {
>> struct trace_branch {
>> struct trace_entry ent;
>> unsigned line;
>> - char func[TRACE_FUNC_SIZE+1];
>> - char file[TRACE_FILE_SIZE+1];
>> + char func[TRACE_FUNC_SIZE];
>> + char file[TRACE_FILE_SIZE];
>> char correct;
>> };
>
> (without change of the TRACE_????_SIZE definition)
>
> Better avoid a categorization of a patch if the change's scope exceeds
> that of the categorization.
I think it's make no sense to change the magic number TRACE_????_SIZE,
I will rewrite my changelog as Frederic suggests.
Thank you very much.
Lai.
next prev parent reply other threads:[~2009-05-20 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-18 11:35 [PATCH] tracing: use strlcpy instead of strncpy Lai Jiangshan
2009-05-18 20:55 ` Jiri Slaby
2009-05-19 1:51 ` Lai Jiangshan
2009-05-19 12:54 ` Stefan Richter
2009-05-20 2:34 ` Lai Jiangshan [this message]
2009-05-19 23:43 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A136C2C.1010107@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox