From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1752866AbZEUFrt@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752866AbZEUFrt (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 May 2009 01:47:49 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751263AbZEUFrk
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 21 May 2009 01:47:40 -0400
Received: from terminus.zytor.com ([198.137.202.10]:58368 "EHLO
	terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750725AbZEUFrj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 May 2009 01:47:39 -0400
Message-ID: <4A14EA86.2060609@zytor.com>
Date: Wed, 20 May 2009 22:45:42 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Masami Hiramatsu <mhiramat@redhat.com>
CC: =?UTF-8?B?UHJ6ZW15c8WCYXcgUGF3ZcWCY3p5aw==?= 
	<przemyslaw@pawelczyk.it>,
       Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
       lkml <linux-kernel@vger.kernel.org>,
       systemtap <systemtap@sources.redhat.com>, kvm <kvm@vger.kernel.org>,
       DLE <dle-develop@lists.sourceforge.net>,
       Jim Keniston <jkenisto@us.ibm.com>,
       Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
       Frederic Weisbecker <fweisbec@gmail.com>,
       Andi Kleen <ak@linux.intel.com>,
       Vegard Nossum <vegard.nossum@gmail.com>, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API
References: <20090520205758.25003.44632.stgit@localhost.localdomain>	 <20090520205805.25003.71314.stgit@localhost.localdomain> <40e92d5b0905201501i1548621xe1ee63aa88129a0@mail.gmail.com> <4A1488A2.30706@redhat.com>
In-Reply-To: <4A1488A2.30706@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Masami Hiramatsu wrote:
>>
>> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
>>
>> which is obviously wrong.
> 
> Oops, right. Anyway, there is no reason that we make it
> executable because it's always called from Makefile.
> So, I think just removing that line is better way.
> 

I suggest leaving in a #!/bin/awk line just for documentation's sake,
though.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.