From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754175AbZEUHmc (ORCPT ); Thu, 21 May 2009 03:42:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751467AbZEUHmX (ORCPT ); Thu, 21 May 2009 03:42:23 -0400 Received: from hera.kernel.org ([140.211.167.34]:51445 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751383AbZEUHmW (ORCPT ); Thu, 21 May 2009 03:42:22 -0400 Message-ID: <4A1505D3.7090306@kernel.org> Date: Thu, 21 May 2009 16:42:11 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, "Eric W. Biederman" Subject: Re: [PATCH 10/20] sysfs: Fix locking and factor out sysfs_sd_setattr References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <1242865694-2100-2-git-send-email-ebiederm@xmission.com> <1242865694-2100-3-git-send-email-ebiederm@xmission.com> <1242865694-2100-4-git-send-email-ebiederm@xmission.com> <1242865694-2100-5-git-send-email-ebiederm@xmission.com> <1242865694-2100-6-git-send-email-ebiederm@xmission.com> <1242865694-2100-7-git-send-email-ebiederm@xmission.com> <1242865694-2100-8-git-send-email-ebiederm@xmission.com> <1242865694-2100-9-git-send-email-ebiederm@xmission.com> <1242865694-2100-10-git-send-email-ebiederm@xmission.com> In-Reply-To: <1242865694-2100-10-git-send-email-ebiederm@xmission.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Thu, 21 May 2009 07:42:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > From: Eric W. Biederman > > Cleanly separate the work that is specific to setting the > attributes of a sysfs_dirent from what is needed to update > the attributes of a vfs inode. > > Additionally grab the sysfs_mutex to keep any nasties from > surprising us when updating the sysfs_dirent. > > Signed-off-by: Eric W. Biederman Acked-by: Tejun Heo -- tejun