Re: [PATCH -tip v6 1/5] x86: instruction decorder API

Masami Hiramatsu
2009-05-20T22:46:32Z

Przemysław Pawełczyk wrote:
> On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@redhat.com> wrote:
>
>> Changes from v5:
>
>> - Use /usr/bin/env to find awk
>
> This is fine, but not in the below case.
>
>> --- /dev/null
>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
>> @@ -0,0 +1,314 @@
>> +#!/usr/bin/env awk -f
>
> Depending on multi-argument shebang is IMO bad. In shebang generally
> (but not in all systems) everything after interpreter part is treated
> as the first argument. Therefore executing your gen-insn-attr-x86.awk
> is equivalent to:
>
> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
>
> which is obviously wrong.

Oops, right. Anyway, there is no reason that we make it
executable because it's always called from Makefile.
So, I think just removing that line is better way.

Thank you,