Re: [PATCH -tip v6 1/5] x86: instruction decorder API

Przemysław Pawełczyk
2009-05-20T22:01:34Z

On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@redhat.com> wrote:

> Changes from v5:

> - Use /usr/bin/env to find awk

This is fine, but not in the below case.

> --- /dev/null
> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
> @@ -0,0 +1,314 @@
> +#!/usr/bin/env awk -f

Depending on multi-argument shebang is IMO bad. In shebang generally
(but not in all systems) everything after interpreter part is treated
as the first argument. Therefore executing your gen-insn-attr-x86.awk
is equivalent to:

/usr/bin/env 'awk -f' gen-insn-attr-x86.awk

which is obviously wrong.

--
Przemysław Pawełczyk