From: Li Zefan <lizf@cn.fujitsu.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Paul Menage <menage@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount
Date: Fri, 22 May 2009 16:35:14 +0800 [thread overview]
Message-ID: <4A1663C2.4080401@cn.fujitsu.com> (raw)
In-Reply-To: <20090522172545.1e5e5f81.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki wrote:
> On Fri, 22 May 2009 11:00:12 +0800
> Li Zefan <lizf@cn.fujitsu.com> wrote:
>
>> Now we have 'stat' file in both memory and cpuacct subsystems. If we
>> mount these 2 subsystems with option 'noprefix', the creation of 'stat'
>> file for cpuacct will fail, but without any notificatin to the user.
>>
>> With this patch, we fail the mount/remount in this case.
>>
>
> Hm, shouldn't we allow "noprefix" to be effective only agaisnt cpuset ?
> I think it's just for backward-compatibility of cpuset.
> (I don't like the option at all.)
>
Yes, this mount option was introduced for cpuset. But it has been here for
a long time and people may use it when mounting other cgroup subsystems,
then is it OK to change to restrict its use within cpuset only?
next prev parent reply other threads:[~2009-05-22 8:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 3:00 [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount Li Zefan
2009-05-22 8:25 ` KAMEZAWA Hiroyuki
2009-05-22 8:35 ` Li Zefan [this message]
2009-05-22 8:34 ` KAMEZAWA Hiroyuki
2009-05-22 9:10 ` Dhaval Giani
2009-05-25 9:14 ` Li Zefan
2009-05-25 9:47 ` Dhaval Giani
2009-05-26 22:06 ` Paul Menage
2009-05-27 1:07 ` Li Zefan
2009-05-27 1:34 ` KAMEZAWA Hiroyuki
2009-05-27 3:24 ` Li Zefan
2009-05-27 6:16 ` KAMEZAWA Hiroyuki
2009-05-25 13:17 ` Balbir Singh
2009-05-26 1:24 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1663C2.4080401@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).