From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758320AbZEVWDw (ORCPT ); Fri, 22 May 2009 18:03:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757454AbZEVWDp (ORCPT ); Fri, 22 May 2009 18:03:45 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:36777 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757139AbZEVWDo (ORCPT ); Fri, 22 May 2009 18:03:44 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4A172131.5010005@s5r6.in-berlin.de> Date: Sat, 23 May 2009 00:03:29 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.21) Gecko/20090411 SeaMonkey/1.1.16 MIME-Version: 1.0 To: linux1394-devel@lists.sourceforge.net CC: linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org, Kay Sievers Subject: Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udev rules References: <4A159899.20506@s5r6.in-berlin.de> <4A165CED.8030601@s5r6.in-berlin.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stefan Richter wrote: > + while (fw_csr_iterator_next(&ci, &key, &value)) { > + if (key != (CSR_UNIT | CSR_DIRECTORY)) > + continue; > + i += units_sprintf(&buf[i], ci.p + value - 1); > + if (i >= PAGE_SIZE - (8 + 1 + 8 + 1)) > + break; > + } > + up_read(&fw_device_rwsem); > + > + sprintf(&buf[i ? i - 1 : 0], "\n"); Rather: if (i) buf[i - 1] = '\n'; > + > + return i; > +} -- Stefan Richter -=====-==--= -=-= =-=== http://arcgraph.de/sr/