From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751062AbZEYHn2 (ORCPT ); Mon, 25 May 2009 03:43:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759413AbZEYHjL (ORCPT ); Mon, 25 May 2009 03:39:11 -0400 Received: from [222.92.8.141] ([222.92.8.141]:36123 "EHLO lemote.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1759265AbZEYHjJ (ORCPT ); Mon, 25 May 2009 03:39:09 -0400 Message-ID: <4A1A4A54.6090401@lemote.com> Date: Mon, 25 May 2009 15:35:48 +0800 From: =?UTF-8?B?6IOh5rSq5YW1?= User-Agent: Mozilla-Thunderbird 2.0.0.9 (X11/20080110) MIME-Version: 1.0 To: yanh@lemote.com CC: Bartlomiej Zolnierkiewicz , wuzhangjin@gmail.com, linux-mips@linux-mips.org, Ralf Baechle , IDE/ATA development list , Linux Kernel , linux-scsi , Philippe Vachon , Zhang Le , Zhang Fuxin , Arnaud Patard , loongson-dev@googlegroups.com, gnewsense-dev@nongnu.org, Nicholas Mc Guire , Liu Junliang , Erwan Lerale Subject: Re: [loongson-PATCH-v1 24/27] fixup for FUJITSU disk References: <200905222032.55869.bzolnier@gmail.com> <1243062702.8509.7.camel@localhost.localdomain> <200905231347.34717.bzolnier@gmail.com> <1243230339.9819.18.camel@localhost.localdomain> In-Reply-To: <1243230339.9819.18.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org yanh 写道: > 在 2009-05-23六的 13:47 +0200，Bartlomiej Zolnierkiewicz写道： > >> On Saturday 23 May 2009 09:11:42 yanh wrote: >> >>> 在 2009-05-22五的 20:32 +0200，Bartlomiej Zolnierkiewicz写道： >>> >>>> On Thursday 21 May 2009 00:12:46 wuzhangjin@gmail.com wrote: >>>> >>>>> From: Wu Zhangjin >>>>> >>>>> This is originally from the to-mips branch from >>>>> http://dev.lemote.com/code/linux_loongson >>>>> >>>> Sadly, the patch description lacks all the important information. >>>> >>>> What is the original problem that this fixup tries to address? >>>> >>>> Is it limited to amd74xx controllers? >>>> >>> In loongson2f yeeloong machines, the ide controller is AMD cs5536, or >>> say amd74xx, and the hard drives is Fujistu. >>> >> Then it should use the new & shiny :) native cs5536 IDE host driver >> instead of legacy support in amd74xx... >> >> >>> While debuging the hard disk suspned and resume, the ide irq can not be >>> cleared. I guess this is a fake interrupt, hence the clear irq action >>> can not be finished. >>> >> AFAICS the only change that the fixup would cause for suspend/resume paths >> is the one in ide_config_drive_speed() which is called during resume to set >> transfer mode on the drive: >> >> tp_ops->write_devctl(hwif, ATA_NIEN | ATA_DEVCTL_OBS); >> >> memset(&tf, 0, sizeof(tf)); >> tf.feature = SETFEATURES_XFER; >> tf.nsect = speed; >> >> tp_ops->tf_load(drive, &tf, IDE_VALID_FEATURE | IDE_VALID_NSECT); >> >> tp_ops->exec_command(hwif, ATA_CMD_SET_FEATURES); >> ---> >> if (drive->quirk_list == 2) >> tp_ops->write_devctl(hwif, ATA_DEVCTL_OBS); >> > > >> ---> >> error = __ide_wait_stat(drive, drive->ready_stat, >> ATA_BUSY | ATA_DRQ | ATA_ERR, >> WAIT_CMD, &stat); >> >> Please tell me I if understand the issue correctly: if the above quirk is >> not executed we end up with spurious IRQs, right? >> > right. > >>> This patch is to fix this issue. Maybe other controller and drives also >>> have this issue, but I am not sure. >>> >> Probably moving it to a generic quirk_drives list later will be useful... >> >> Anyway this fixup needs to be ported to / verified with cs5536 first. >> > the cs5536 pata driver have some geode platform dependent codes. We can > just ignore it, but the performance is poor(using hdparm to test it), > which only get 22+ MB/s. we find it only use udma2. However if using > amd74xx driver, it can set udma5, and the speed can reach to 50+ MB/s. > > we will test whether this driver is working well without this patch. > > Anyway, thanks your advice. > Use the driver drivers/ata/pata_cs5536.c, unfortunately it also have the same issue. >> Thanks. >> Bart >> >> > > > > -- --------------------------------------------------------- Hongbing,Hu (Software Department) Tel: 0512-52308631 E-mail: huhb@lemote.com MSN: [huhb04@gmail.com] JiangSu Lemote Corp. Ltd. MengLan, Yushan, Changshu, JiangSu Province, China ---------------------------------------------------------