public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	ebiederm@xmission.com, roland@redhat.com,
	linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: Re: [PATCH 1/1] signal: make group kill signal fatal
Date: Mon, 25 May 2009 20:15:09 +0200	[thread overview]
Message-ID: <4A1AE02D.5080701@gmail.com> (raw)
In-Reply-To: <20090525172033.GA12586@redhat.com>

On 05/25/2009 07:20 PM, Oleg Nesterov wrote:
> On 05/25, Jiri Slaby wrote:
>> If the poll isn't there, it works well.
> 
> Hmm. this is strange. Do you mean that if this program does
> sleep(10000) (or something else) instead of poll() above, it
> prints pend != 0 ?

No, only when there is nothing, i.e. when it directly calls close. It's
consistent with what you wrote. When there is sleep(), it works the same
as the poll case.

> And. Why do you need fatal_signal_pending() ? It is special,
> should be used by things like wait_event_killable().

I need to wait for a device to finish its work in last release, but also
want to allow user to kill the waiting by SIGKILL if he thinks the
device locked up (this is pretty usual for that particular device). If I
use wait_event_killable, I end up with this.

Well, there is a STOP ioctl and a user should catch sigterm/int/quit and
call that ioctl and bail out. But users are weird and get unkillable
processes.

Anyway thanks for the clarification.

  reply	other threads:[~2009-05-25 18:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24 20:47 [PATCH 1/1] signal: make group kill signal fatal Jiri Slaby
2009-05-25  0:07 ` Oleg Nesterov
2009-05-25 16:21   ` Jiri Slaby
2009-05-25 17:20     ` Oleg Nesterov
2009-05-25 18:15       ` Jiri Slaby [this message]
2009-05-25 22:51         ` Oleg Nesterov
2009-06-02 12:54           ` Jiri Slaby
2009-06-02 14:50             ` Oleg Nesterov
2009-06-03  1:52               ` Roland McGrath
2009-06-04  2:27                 ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A1AE02D.5080701@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox