From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365AbZE2JSF (ORCPT ); Fri, 29 May 2009 05:18:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756058AbZE2JRy (ORCPT ); Fri, 29 May 2009 05:17:54 -0400 Received: from hera.kernel.org ([140.211.167.34]:42635 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276AbZE2JRy (ORCPT ); Fri, 29 May 2009 05:17:54 -0400 Message-ID: <4A1FA7F4.9000708@kernel.org> Date: Fri, 29 May 2009 18:16:36 +0900 From: Tejun Heo User-Agent: Thunderbird 2.0.0.19 (X11/20081227) MIME-Version: 1.0 To: "Eric W. Biederman" CC: Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Cornelia Huck , linux-fsdevel@vger.kernel.org, Kay Sievers , Greg KH , "Eric W. Biederman" Subject: Re: [PATCH 22/24] sysfs: Make sysfs_rename_link atomic References: <1243551665-23596-22-git-send-email-ebiederm@xmission.com> In-Reply-To: <1243551665-23596-22-git-send-email-ebiederm@xmission.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (hera.kernel.org [127.0.0.1]); Fri, 29 May 2009 09:16:38 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman wrote: > From: Eric W. Biederman > > Use the existing sysfs_rename to make sysfs_rename_link an atomic > operation that does less work. While I am at add additional sanity > checking to ensure it is a symlink I am renaming. > > Acked-by: Kay Sievers > Signed-off-by: Eric W. Biederman It would be really nice to merge or group this together with the first three patches. Other than that, Acked-by: Tejun Heo -- tejun