Re: [PATCH 22/24] sysfs: Make sysfs_rename_link atomic

Eric W. Biederman
2009-05-29T17:18:13Z

Tejun Heo <tj@kernel.org> writes:

> Eric W. Biederman wrote:
>> From: Eric W. Biederman <ebiederm@xmission.com>
>>
>> Use the existing sysfs_rename to make sysfs_rename_link an atomic
>> operation that does less work. While I am at add additional sanity
>> checking to ensure it is a symlink I am renaming.
>>
>> Acked-by: Kay Sievers <kay.sievers@vrfy.org>
>> Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
>
> It would be really nice to merge or group this together with the first
> three patches. Other than that,

Perfection is the enemy of the good on that one. That just convolutes
things unnecessarily, makes the patches harder to review, and requires
additional testing.

I much prefer to work in a tree without rewinding.

> Acked-by: Tejun Heo <tj@kernel.org>
>
> --
> tejun