Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link

Kay Sievers
2009-05-21T11:40:33Z

On Thu, May 21, 2009 at 12:29, Eric W. Biederman <ebiederm@xmission.com> wrote:
> Kay Sievers <kay.sievers@vrfy.org> writes:

>> The target string is composed on-demand, and it always points to the
>> same kobject and *targ is not needed, right?
>>
>> Can't we just change the name of the link, instead of removing and
>> re-creating the entire thing, and all these issues go away?
>
> Good point.  It looks like I can generalize sysfs_mv_dir into simply
> being sysfs_rename.  All of the existing logic looks like it can handle
> that.  I will look at doing an incremental patch for that.

Nice, would be great, if that can be made working. It would be much
better than the current logic, and there would be no ordering problem,
like Tejun mentioned, to solve anymore.

As we don't need to change the target for link, maybe:
sysfs_rename_file(kobj_parent, old_name, new_name);
that can act on symlinks and regular files would be useful?

Thanks,
Kay