[PATCH 1/1] Char: mxser, fix ISA board lookup

[PATCH 1/1] Char: mxser, fix ISA board lookup

[Jiri Slaby]

From: "Peter Botha" <peterb@goldcircle.co.za>

There's a bug in the mxser kernel module that still appears in the 2.6.29.4
kernel.

mxser_get_ISA_conf takes a ioaddress as it's first argument, by passing the
not of the ioaddr, you're effectively passing 0
which means it won't be able to talk to an ISA card.
I have tested this, and removing the ! fixes the problem.

Cc: "Peter Botha" <peterb@goldcircle.co.za>
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
 drivers/char/mxser.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index 6dfef56..9533f43 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -2715,7 +2715,7 @@ static int __init mxser_module_init(void)
 			continue;
 
 		brd = &mxser_boards[m];
-		retval = mxser_get_ISA_conf(!ioaddr[b], brd);
+		retval = mxser_get_ISA_conf(ioaddr[b], brd);
 		if (retval <= 0) {
 			brd->info = NULL;
 			continue;
-- 
1.6.3

Re: [PATCH 1/1] Char: mxser, fix ISA board lookup

[Jiri Slaby]

On 05/29/2009 05:53 PM, Jiri Slaby wrote:
> From: "Peter Botha" <peterb@goldcircle.co.za>
> 
> There's a bug in the mxser kernel module that still appears in the 2.6.29.4
> kernel.
> 
> mxser_get_ISA_conf takes a ioaddress as it's first argument, by passing the
> not of the ioaddr, you're effectively passing 0
> which means it won't be able to talk to an ISA card.
> I have tested this, and removing the ! fixes the problem.
> 
> Cc: "Peter Botha" <peterb@goldcircle.co.za>

It would be good if you could add your Signed-off-by here.

> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>