From: "H. Peter Anvin" <hpa@zytor.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
seto.hidetoshi@jp.fujitsu.com, tglx@linutronix.de,
linux-tip-commits@vger.kernel.org, apw@canonical.com
Subject: Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c
Date: Fri, 29 May 2009 13:18:27 -0700 [thread overview]
Message-ID: <4A204313.9090102@zytor.com> (raw)
In-Reply-To: <20090529200305.GC1065@one.firstfloor.org>
Andi Kleen wrote:
>> x86, mce: trivial clean up for mce_intel_64.c
>>
>> Fix for:
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> + for_each_online_cpu (cpu) {
>
> Sorry but that's just a bogus change. That's a loop and we always
> put spaces between the loop keyword and its condition.
>
> Just because checkpatch.pl is too dumb to understand that is no
> reason to make the code worse like that.
>
Look at EVERY OTHER for_each_online_cpu in the kernel.
-hpa
prev parent reply other threads:[~2009-05-29 20:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-61a021a0700c22ee527d73d92f9acb109ff478f8@git.kernel.org>
2009-05-29 20:03 ` [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c Andi Kleen
2009-05-29 20:18 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A204313.9090102@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox