* Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c
[not found] <tip-61a021a0700c22ee527d73d92f9acb109ff478f8@git.kernel.org>
@ 2009-05-29 20:03 ` Andi Kleen
2009-05-29 20:18 ` H. Peter Anvin
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2009-05-29 20:03 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, andi, seto.hidetoshi, tglx
Cc: linux-tip-commits, apw
> x86, mce: trivial clean up for mce_intel_64.c
>
> Fix for:
>
> WARNING: space prohibited between function name and open parenthesis '('
> + for_each_online_cpu (cpu) {
Sorry but that's just a bogus change. That's a loop and we always
put spaces between the loop keyword and its condition.
Just because checkpatch.pl is too dumb to understand that is no
reason to make the code worse like that.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c
2009-05-29 20:03 ` [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c Andi Kleen
@ 2009-05-29 20:18 ` H. Peter Anvin
0 siblings, 0 replies; 2+ messages in thread
From: H. Peter Anvin @ 2009-05-29 20:18 UTC (permalink / raw)
To: Andi Kleen
Cc: linux-kernel, mingo, seto.hidetoshi, tglx, linux-tip-commits, apw
Andi Kleen wrote:
>> x86, mce: trivial clean up for mce_intel_64.c
>>
>> Fix for:
>>
>> WARNING: space prohibited between function name and open parenthesis '('
>> + for_each_online_cpu (cpu) {
>
> Sorry but that's just a bogus change. That's a loop and we always
> put spaces between the loop keyword and its condition.
>
> Just because checkpatch.pl is too dumb to understand that is no
> reason to make the code worse like that.
>
Look at EVERY OTHER for_each_online_cpu in the kernel.
-hpa
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-29 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tip-61a021a0700c22ee527d73d92f9acb109ff478f8@git.kernel.org>
2009-05-29 20:03 ` [tip:x86/mce3] x86, mce: trivial clean up for mce_intel_64.c Andi Kleen
2009-05-29 20:18 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox