From: Ian molton <spyro@f2s.com>
To: pHilipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, Pierre Ossman <pierre@ossman.eu>
Subject: Re: [PATCH 2/5] mmc: tmio_mmc: add bus_shift support
Date: Sat, 30 May 2009 11:36:47 +0100 [thread overview]
Message-ID: <4A210C3F.1070408@f2s.com> (raw)
In-Reply-To: <74d0deb30905261316hd100bbdr96e5e544eed94c2e@mail.gmail.com>
pHilipp Zabel wrote:
> On Mon, May 25, 2009 at 9:27 PM, Philipp Zabel <philipp.zabel@gmail.com> wrote:
>> Some ASIC3 devices in the wild are connected with the address bus shifted
>> by one line, so that its 16-bit registers appear 32-bit aligned in host
>> memory space.
>
> This patch has to be amended:
I have to assume that this works - I have no asic3 hardware, and bus
shift is zero on TMIO hardware, so this didnt cause issues.
This modification acked too.
next prev parent reply other threads:[~2009-05-30 10:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 19:27 [PATCH 0/6] Preparations for ASIC3 support in the TMIO MMC driver Philipp Zabel
2009-05-25 19:27 ` [PATCH 1/5] MFD,mmc: tmio_mmc: make HCLK configurable Philipp Zabel
2009-05-29 11:20 ` Samuel Ortiz
2009-05-29 12:36 ` Pierre Ossman
2009-05-30 9:59 ` Ian molton
2009-05-30 11:40 ` pHilipp Zabel
2009-05-30 11:56 ` Ian Molton
2009-05-25 19:27 ` [PATCH 2/5] mmc: tmio_mmc: add bus_shift support Philipp Zabel
2009-05-26 20:16 ` pHilipp Zabel
2009-05-26 21:13 ` Ian molton
2009-05-30 10:36 ` Ian molton [this message]
2009-05-30 11:45 ` pHilipp Zabel
2009-05-30 10:26 ` Ian molton
2009-05-30 11:46 ` pHilipp Zabel
2009-06-03 20:28 ` Pierre Ossman
2009-05-25 19:27 ` [PATCH 3/5] mmc: tmio_mmc: don't use set_irq_type Philipp Zabel
2009-05-30 10:34 ` Ian molton
2009-06-03 20:29 ` Pierre Ossman
2009-05-25 19:28 ` [PATCH 4/5] mmc: tmio_mmc: correct probe return value for num_resources != 3 Philipp Zabel
2009-05-30 11:28 ` Ian molton
2009-05-25 19:28 ` [PATCH 5/5] mmc: tmio_mmc: move probe function into __init section Philipp Zabel
2009-05-27 20:21 ` Pierre Ossman
2009-05-30 11:36 ` Ian molton
2009-05-30 11:47 ` pHilipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A210C3F.1070408@f2s.com \
--to=spyro@f2s.com \
--cc=ian@mnementh.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.zabel@gmail.com \
--cc=pierre@ossman.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox