Re: [PATCH 0/4] amd64_edac: misc fixes

Borislav Petkov
2009-05-30T10:31:22Z

On Sat, May 30, 2009 at 01:40:07AM -0700, Andrew Morton wrote:
> On Sat, 30 May 2009 10:19:54 +0200 Borislav Petkov <petkovbb@googlemail.com> wrote:
>
> > Also, I've been thinking about how the old(er)
> > toolchain problem can be addressed and one fairly doable thing would be
> > if I'd query the gas version in the kernel Makefile and define popcnt
> > dependent on it and for older assemblers simply slap in the opcode and
> > fixate the operands in an inline assembly so that it works.
>
> We've done that before. BUG() is one case (for other reasons), I think.
>
> But if we have the code in there which uese the literal opcode, there's
> no need to query gas or to add the conditional.

Right, we can do that too. Stay tuned.

> Is popcnt supported on all CPUs?

All >= Fam10h.

--
Regards/Gruss,
Boris.