From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754990AbZEaBhk (ORCPT ); Sat, 30 May 2009 21:37:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754007AbZEaBhc (ORCPT ); Sat, 30 May 2009 21:37:32 -0400 Received: from mail.windriver.com ([147.11.1.11]:35944 "EHLO mail.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753469AbZEaBhb (ORCPT ); Sat, 30 May 2009 21:37:31 -0400 Message-ID: <4A21DE75.7010202@windriver.com> Date: Sun, 31 May 2009 09:33:41 +0800 From: Harry Ciao Reply-To: qingtao.cao@windriver.com Organization: Wind River, CDC User-Agent: Thunderbird 2.0.0.12 (X11/20080227) MIME-Version: 1.0 To: Andrew Morton CC: norsk5@yahoo.com, linux-kernel@vger.kernel.org, bluesmoke-devel@lists.sourceforge.net Subject: Re: [v1 PATCH 0/2] EDAC: AMD8111 & AMD8131 Kconfig fixup References: <1242358006-28339-1-git-send-email-qingtao.cao@windriver.com> <20090528004433.4051e83d.akpm@linux-foundation.org> In-Reply-To: <20090528004433.4051e83d.akpm@linux-foundation.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 31 May 2009 01:33:09.0647 (UTC) FILETIME=[C14E31F0:01C9E18F] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton wrote: > On Fri, 15 May 2009 11:26:44 +0800 Harry Ciao wrote: > > >> These are two minor fixups for the AMD8111 and AMD8131 EDAC drivers. >> The direct reference to device.bus_id should be replaced by dev_name(). >> >> Add their missing Makefile entires and introduce machine dependency to >> their Kconfig options in order to avoid the allmodconfig failure, which >> I have no better idea to avoid although these chips are not specific to >> Maple. >> > > OK, thanks. > > Do you think these fixes are safe and desirable for 2.6.30? (I do). > > Hi Andrew, Yes I think so too, I have tested these patches and they work well. Thanks! Harry