From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/events: fix a typo in __string() format output
Date: Sun, 31 May 2009 13:58:23 +0800 [thread overview]
Message-ID: <4A221C7F.70403@cn.fujitsu.com> (raw)
In-Reply-To: <4A1F558B.2050705@cn.fujitsu.com>
ping..
Could someone apply this patch? I have a patchset, that
introduces __dynamic_array(), based on this fix.
Or I will include this fix in the patchset.
Li Zefan wrote:
> It should be '\t'. Also remove the space before "__str_loc".
>
> Before:
> # cat tracing/events/irq/irq_handler_entry/format
> ...
> field:int irq; offset:12; size:4;
> field: __str_loc name; offset:16;tsize:2;
> ...
>
> After:
> # cat tracing/events/irq/irq_handler_entry/format
> ...
> field:int irq; offset:12; size:4;
> field:__str_loc name; offset:16; size:2;
> ...
>
> [ Impact: fix the output of __string field in format file ]
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> include/trace/ftrace.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> index edb02bc..006af4c 100644
> --- a/include/trace/ftrace.h
> +++ b/include/trace/ftrace.h
> @@ -187,8 +187,8 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \
>
> #undef __string
> #define __string(item, src) \
> - ret = trace_seq_printf(s, "\tfield: __str_loc " #item ";\t" \
> - "offset:%u;tsize:%u;\n", \
> + ret = trace_seq_printf(s, "\tfield:__str_loc " #item ";\t" \
> + "offset:%u;\tsize:%u;\n", \
> (unsigned int)offsetof(typeof(field), \
> __str_loc_##item), \
> (unsigned int)sizeof(field.__str_loc_##item)); \
next prev parent reply other threads:[~2009-05-31 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-29 3:24 [PATCH] tracing/events: fix a typo in __string() format output Li Zefan
2009-05-31 5:58 ` Li Zefan [this message]
2009-05-31 14:21 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A221C7F.70403@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox