From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756232AbZEaF5M (ORCPT ); Sun, 31 May 2009 01:57:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753076AbZEaF46 (ORCPT ); Sun, 31 May 2009 01:56:58 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:64855 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754700AbZEaF45 (ORCPT ); Sun, 31 May 2009 01:56:57 -0400 Message-ID: <4A221C7F.70403@cn.fujitsu.com> Date: Sun, 31 May 2009 13:58:23 +0800 From: Li Zefan User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Steven Rostedt , Frederic Weisbecker CC: Ingo Molnar , LKML Subject: Re: [PATCH] tracing/events: fix a typo in __string() format output References: <4A1F558B.2050705@cn.fujitsu.com> In-Reply-To: <4A1F558B.2050705@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ping.. Could someone apply this patch? I have a patchset, that introduces __dynamic_array(), based on this fix. Or I will include this fix in the patchset. Li Zefan wrote: > It should be '\t'. Also remove the space before "__str_loc". > > Before: > # cat tracing/events/irq/irq_handler_entry/format > ... > field:int irq; offset:12; size:4; > field: __str_loc name; offset:16;tsize:2; > ... > > After: > # cat tracing/events/irq/irq_handler_entry/format > ... > field:int irq; offset:12; size:4; > field:__str_loc name; offset:16; size:2; > ... > > [ Impact: fix the output of __string field in format file ] > > Signed-off-by: Li Zefan > --- > include/trace/ftrace.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > index edb02bc..006af4c 100644 > --- a/include/trace/ftrace.h > +++ b/include/trace/ftrace.h > @@ -187,8 +187,8 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \ > > #undef __string > #define __string(item, src) \ > - ret = trace_seq_printf(s, "\tfield: __str_loc " #item ";\t" \ > - "offset:%u;tsize:%u;\n", \ > + ret = trace_seq_printf(s, "\tfield:__str_loc " #item ";\t" \ > + "offset:%u;\tsize:%u;\n", \ > (unsigned int)offsetof(typeof(field), \ > __str_loc_##item), \ > (unsigned int)sizeof(field.__str_loc_##item)); \