Re: [PATCH] tracing/events: fix a typo in __string() format output

Li Zefan
2009-05-31T05:57:12Z

ping..

Could someone apply this patch? I have a patchset, that
introduces __dynamic_array(), based on this fix.

Or I will include this fix in the patchset.

Li Zefan wrote:
> It should be '\t'. Also remove the space before "__str_loc".
>
> Before:
> # cat tracing/events/irq/irq_handler_entry/format
> ...
> field:int irq; offset:12; size:4;
> field: __str_loc name; offset:16;tsize:2;
> ...
>
> After:
> # cat tracing/events/irq/irq_handler_entry/format
> ...
> field:int irq; offset:12; size:4;
> field:__str_loc name; offset:16; size:2;
> ...
>
> [ Impact: fix the output of __string field in format file ]
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
> include/trace/ftrace.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> index edb02bc..006af4c 100644
> --- a/include/trace/ftrace.h
> +++ b/include/trace/ftrace.h
> @@ -187,8 +187,8 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \
>
> #undef __string
> #define __string(item, src) \
> - ret = trace_seq_printf(s, "\tfield: __str_loc " #item ";\t" \
> - "offset:%u;tsize:%u;\n", \
> + ret = trace_seq_printf(s, "\tfield:__str_loc " #item ";\t" \
> + "offset:%u;\tsize:%u;\n", \
> (unsigned int)offsetof(typeof(field), \
> __str_loc_##item), \
> (unsigned int)sizeof(field.__str_loc_##item)); \