From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758234AbZEaOiy (ORCPT ); Sun, 31 May 2009 10:38:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755284AbZEaOiq (ORCPT ); Sun, 31 May 2009 10:38:46 -0400 Received: from mx2.redhat.com ([66.187.237.31]:36716 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbZEaOip (ORCPT ); Sun, 31 May 2009 10:38:45 -0400 Message-ID: <4A22965A.6030201@redhat.com> Date: Sun, 31 May 2009 10:38:18 -0400 From: Rik van Riel Organization: Red Hat, Inc User-Agent: Thunderbird 2.0.0.17 (X11/20080915) MIME-Version: 1.0 To: "Larry H." CC: linux-kernel@vger.kernel.org, pageexec@freemail.hu, linux-mm@kvack.org, Linus Torvalds , Alan Cox Subject: Re: [PATCH] Use kzfree in crypto API context initialization and key/iv handling References: <20090531025720.GC9033@oblivion.subreption.com> In-Reply-To: <20090531025720.GC9033@oblivion.subreption.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Larry H. wrote: > [PATCH] Use kzfree in crypto API context initialization and key/iv handling > > This patch replaces the kfree() calls within the crypto API (algorithms, > key setup and handling, etc) with kzfree(), to enforce sanitization of > the allocated memory. > > This prevents such information from persisting on memory and eventually > leak to other kernel users or during coldboot attacks. > > This patch replaces kfree() for context (algorithm meta-data) structures > too. Those are initialized or released once, and remain in use during the > lifetime of the cipher/algorithm instance, therefore no performance impact > exists for those specific changes. > > This patch doesn't affect fastpaths. > > Signed-off-by: Larry Highsmith Acked-by: Rik van Riel -- All rights reversed.