From: Jiri Slaby <jirislaby@gmail.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scripts: allow docproc invocation from external
Date: Mon, 01 Jun 2009 19:02:11 +0200 [thread overview]
Message-ID: <4A240993.8030409@gmail.com> (raw)
In-Reply-To: <4A23FC2C.4060602@oracle.com>
On 06/01/2009 06:05 PM, Randy Dunlap wrote:
> Jiri Slaby wrote:
>> - getcwd returns path without a slash at the end, add the slash
>
> Hi Jiri,
>
> This part (above) fixes a bug, right?
Yes, but the bug is not triggered when building from a kernel tree.
>> - add KBUILD_SRC env support, so that we can specify path for
>> kernel (to know where scripts/kernel-doc resides) and SRCTREE
>> (for searching files referenced in .tmpl) separately
>
> Can you explain your usage a bit more so that I can understand some
> justification for this change? (not that I'm objecting to it)
Sure, I have out-of-kernel drivers (which I plan to merge, but keep
out-of-tree development anyway) and have this in a makefile:
%.xml: %.tmpl
KBUILD_SRC=$(KSRC) $(KDIR)/scripts/basic/docproc doc $^ > $@
so that I can build documentation from a .tmpl file for those drivers.
SRCTREE defaults to cwd, so it finds sources referenced from the .tmpl
file in current location. What didn't work is execution of
scripts/kernel-doc. This is now executed with KBUILD_SRC prepended,
which is what it should be.
next prev parent reply other threads:[~2009-06-01 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 16:05 [PATCH 1/1] scripts: allow docproc invocation from external Jiri Slaby
2009-06-01 16:05 ` Randy Dunlap
2009-06-01 17:02 ` Jiri Slaby [this message]
2009-06-05 21:45 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-06-16 14:29 William Cohen
2009-01-05 14:08 Jiri Slaby
2009-01-07 19:55 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A240993.8030409@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox