From: Roel Kluin <roel.kluin@gmail.com>
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] tracing/mm: val should be signed
Date: Wed, 03 Jun 2009 00:57:20 +0200 [thread overview]
Message-ID: <4A25AE50.4090108@gmail.com> (raw)
If not signed the `val < 0' test below doesn't make sense.
Also strict_strtol requires a long pointer.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I think this is what was intended? please review.
diff --git a/kernel/trace/trace_mm.c b/kernel/trace/trace_mm.c
index 4bc7fc0..9af2351 100644
--- a/kernel/trace/trace_mm.c
+++ b/kernel/trace/trace_mm.c
@@ -54,7 +54,8 @@ static ssize_t
trace_mm_dump_range_write(struct file *filp, const char __user *ubuf, size_t cnt,
loff_t *ppos)
{
- unsigned long val, start, end;
+ unsigned long start, end;
+ long val;
char buf[64];
int ret;
reply other threads:[~2009-06-02 20:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A25AE50.4090108@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox