public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tracing/mm: val should be signed
@ 2009-06-02 22:57 Roel Kluin
  0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-06-02 22:57 UTC (permalink / raw)
  To: rostedt; +Cc: linux-kernel, Andrew Morton

If not signed the `val < 0' test below doesn't make sense.
Also strict_strtol requires a long pointer.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
I think this is what was intended? please review.

diff --git a/kernel/trace/trace_mm.c b/kernel/trace/trace_mm.c
index 4bc7fc0..9af2351 100644
--- a/kernel/trace/trace_mm.c
+++ b/kernel/trace/trace_mm.c
@@ -54,7 +54,8 @@ static ssize_t
 trace_mm_dump_range_write(struct file *filp, const char __user *ubuf, size_t cnt,
 		       loff_t *ppos)
 {
-	unsigned long val, start, end;
+	unsigned long start, end;
+	long val;
 	char buf[64];
 	int ret;
 

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-02 20:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-02 22:57 [PATCH] tracing/mm: val should be signed Roel Kluin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox