Re: [RESEND] [PATCH v2] [BUGFIX] x86/x86_64: fix CPU offlining triggered "active" device IRQ interrruption

Gary Hade
2009-06-04T21:19:17Z

On Thu, Jun 04, 2009 at 01:04:37PM -0700, Gary Hade wrote:
> On Wed, Jun 03, 2009 at 02:13:23PM -0700, Eric W. Biederman wrote:
> > Gary Hade <garyhade@us.ibm.com> writes:
> >
> > > Correct, after the fix was applied my testing did _not_ show
> > > the lockups that you are referring to. I wonder if there is a
> > > chance that the root cause of those old failures and the root
> > > cause of issue that my fix addresses are the same?
> > >
> > > Can you provide the test case that demonstrated the old failure
> > > cases so I can try it on our systems? Also, do you recall what
> > > mainline version demonstrated the old failure
> >
> > The irq migration has already been moved to interrupt context by the
> > time I started working on it. And I managed to verify that there were
> > indeed problems with moving it out of interrupt context before my code
> > merged.
> >
> > So if you want to reproduce it reduce your irq migration to the essentials.
> > Set IRQ_MOVE_PCNTXT, and always migrate the irqs from process context
> > immediately.
> >
> > Then migrate an irq that fires at a high rate rapidly from one cpu to
> > another.
> >
> > Right now you are insulated from most of the failures because you still
> > don't have IRQ_MOVE_PCNTXT. So you are only really testing your new code
> > in the cpu hotunplug path.
>
> OK, I'm confused.
>
> It sounds like you want me force IRQ_MOVE_PCNTXT so that I can
> test in a configuration that you say is already broken. Why
> in the heck would this config, where you expect lockups without
> the fix, be a productive environment in which to test the fix?

Sorry, I did not say this well. Trying again:

Why would this config, where you already expect lockups
for reasons that you say are not addressed by the fix, be
a productive environment in which to test the fix?

Gary

--
Gary Hade
System x Enablement
IBM Linux Technology Center
503-578-4503 IBM T/L: 775-4503
garyhade@us.ibm.com