Re: [RESEND] [PATCH v2] [BUGFIX] x86/x86_64: fix CPU offlining triggered "active" device IRQ interrruption

Eric W. Biederman
2009-06-03T12:03:33Z

Gary Hade <garyhade@us.ibm.com> writes:

> Impact: Eliminates an issue that can leave the system in an
> unusable state.
>
> This patch addresses an issue where device generated IRQs
> are no longer seen by the kernel following IRQ affinity
> migration while the device is generating IRQs at a high rate.
>
> I have been able to consistently reproduce the problem on
> some of our systems by running the following script (VICTIM_IRQ
> specifies the IRQ for the aic94xx device) while a single instance
> of the command
> # while true; do find / -exec file {} \;; done
> is keeping the filesystem activity and IRQ rate reasonably high.

Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Again you are attempt to work around the fact that fixup_irqs
is broken.

fixup_irqs is what needs to be fixed to call these functions properly.

We have several intense debug sessions by various people including
myself that show that your delayed_irq_move function will simply not
work reliably.

Frankly simply looking at it gives me the screaming heebie jeebies.

The fact you can't reproduce the old failure cases which demonstrated
themselves as lockups in the ioapic state machines gives me no
confidence in your testing of this code.

Eric