From: Amerigo Wang <amwang@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-kbuild@vger.kernel.org
Subject: Re: [Patch 1/2] kbuild: two trivial fixes for check headers
Date: Thu, 04 Jun 2009 17:23:10 +0800 [thread overview]
Message-ID: <4A27927E.9090800@redhat.com> (raw)
In-Reply-To: <20090604091519.GA9571@uranus.ravnborg.org>
Sam Ravnborg wrote:
> On Thu, Jun 04, 2009 at 04:01:52AM -0400, Amerigo Wang wrote:
>
>> Remove a useless 'extern' in an exported header.
>> Fix a comment headers_check.pl.
>>
>
> These two patches has nothing in commom.
>
They are both about kernel headers stuff.
>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
>> Cc: Sam Ravnborg <sam@ravnborg.org>
>>
>> ------
>> diff --git a/include/mtd/jffs2-user.h b/include/mtd/jffs2-user.h
>> index fa94b0e..10dc7ef 100644
>> --- a/include/mtd/jffs2-user.h
>> +++ b/include/mtd/jffs2-user.h
>> @@ -18,7 +18,7 @@
>> #undef je32_to_cpu
>> #undef jemode_to_cpu
>>
>> -extern int target_endian;
>> +int target_endian;
>>
>
> You now declare a global variable named target_endian each time you include this file - which is wrong.
>
Why? 'make headers_check' complains about it.
next prev parent reply other threads:[~2009-06-04 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 8:01 [Patch 1/2] kbuild: two trivial fixes for check headers Amerigo Wang
2009-06-04 8:02 ` [Patch 2/2] kbuild: clean up scripts/headers.sh Amerigo Wang
2009-06-04 9:15 ` [Patch 1/2] kbuild: two trivial fixes for check headers Sam Ravnborg
2009-06-04 9:23 ` Amerigo Wang [this message]
2009-06-04 10:39 ` Sam Ravnborg
2009-06-05 2:05 ` Amerigo Wang
2009-06-05 2:23 ` Jaswinder Singh Rajput
2009-06-04 9:56 ` Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A27927E.9090800@redhat.com \
--to=amwang@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox