Re: [PATCH] [2/2] KVM: Add VT-x machine check support

Andi Kleen
2009-06-04T13:13:19Z

On Thu, Jun 04, 2009 at 04:10:14PM +0300, Avi Kivity wrote:
> Andi Kleen wrote:
> >>vmcs access work because we have a preempt notifier called when we are
> >>scheduled in, and will execute vmclear/vmptrld as necessary. Look at
> >>kvm_preempt_ops in virt/kvm_main.c.
> >>
> >
> >I see. So we need to move that check earlier. Do you have a preference
> >where it should be?
> >
>
> There's no good place as it breaks the nice exit handler table. You
> could put it in vmx_complete_interrupts() next to NMI handling.

I think I came up with a easy cheesy but not too bad solution now that should
work. It simply remembers the CPU in the vcpu structure and schedules back to
it. That's fine for this purpose.

Currently testing the patch.

-Andi

--
ak@linux.intel.com -- Speaking for myself only.