Re: [PATCH] [2/2] KVM: Add VT-x machine check support

Avi Kivity
2009-06-04T13:10:41Z

Andi Kleen wrote:
>> vmcs access work because we have a preempt notifier called when we are
>> scheduled in, and will execute vmclear/vmptrld as necessary. Look at
>> kvm_preempt_ops in virt/kvm_main.c.
>>
>
> I see. So we need to move that check earlier. Do you have a preference
> where it should be?
>

There's no good place as it breaks the nice exit handler table. You
could put it in vmx_complete_interrupts() next to NMI handling.

--
error compiling committee.c: too many arguments to function