Re: [PATCH] gpio: Added timbgpio

["Richard Ršöjfors" <richard.rojfors.ext@mocean-labs.com>]

Andrew Morton wrote:
> On Wed, 03 Jun 2009 10:07:48 +0200 Richard R____jfors  <richard.rojfors.ext@mocean-labs.com> wrote:
> 
>> Supplied is a GPIO driver for the Timberdale FPGA found on the
>> Intel Atom board Russellville.
>>
>> ...
>>
>> +EXPORT_SYMBOL(timbgpio_gpio_flnk_lvl_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_int_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_lvl_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_int_clr);
> 
> Why all these module exports?

Internal stuff, I will remove it.

>> ...
>>
>> +config GPIO_TIMBERDALE
>> +	tristate "Support for timberdale GPIO"
>> +	depends on MFD_TIMBERDALE && GPIOLIB
>> +	---help---
>> +	Add support for GPIO usage of some pins of the timberdale FPGA.
>> +
> 
> I cannot find anything which sets MFD_TIMBERDALE anywhere?

Sorry, I realize I have to come back with a bigger patch set.

Timberdale is the MFD driver for the FPGA which among other expose this GPIO device.
This patch set will depend on patches in i2c-ocores and xilinx_spi which I have posted
earlier on the corresponding mailinglists.
Shall I repost those driver changes within this patch set, or can I leave them out?

--Richard